support login authentication #902
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olekskov
suggested changes
Jan 8, 2024
| @@ -11,6 +13,16 @@ public class AuthenticationService { | |||
| * Return false in any other cases. | |||
| */ | |||
| public boolean login(String email, String password) { | |||
| return false; | |||
| UserService useService = new UserService(); | |||
There was a problem hiding this comment.
Please initialize services you rely on in class variable not to create new object each time method is called
Comment on lines
19
to
26
| if (user == null) { | ||
| return false; | ||
| } | ||
|
|
||
| if (!user.getPassword().equals(password)) { | ||
| return false; | ||
| } | ||
| return true; |
There was a problem hiding this comment.
if structure usually not required when we aim to return boolean value
Suggested change
| if (user == null) { | |
| return false; | |
| } | |
| if (!user.getPassword().equals(password)) { | |
| return false; | |
| } | |
| return true; | |
| return user != null && user.getPassword().equals(password); |
okuzan
approved these changes
Jan 9, 2024
| @@ -15,6 +15,11 @@ public class UserService { | |||
| * Return <code>null</code> if there is no suitable user | |||
| */ | |||
| public User findByEmail(String email) { | |||
| for (User user:users) { | |||
There was a problem hiding this comment.
Suggested change
| for (User user:users) { | |
| for (User user : users) { |
make sure to format your file (Ctrl Alt L)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.